Add fallback for _CCCL_BUILTIN_EXPECT#8043
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Mar 16, 2026
Merged
Conversation
miscco
approved these changes
Mar 16, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 22m: Pass: 100%/99 | Total: 3d 06h | Max: 4h 22m | Hits: 78%/256958See results here. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
(cherry picked from commit 5c44b15)
Contributor
|
Successfully created backport PR for |
fbusato
reviewed
Mar 16, 2026
| #endif // _CCCL_CHECK_BUILTIN(builtin_expect) | ||
| # define _CCCL_BUILTIN_EXPECT(_EXPR, _VAL) __builtin_expect(_EXPR, _VAL) | ||
| #else // ^^^ has __builtin_expect ^^^ / vvv no __builtin_expect vvv | ||
| # define _CCCL_BUILTIN_EXPECT(_EXPR, _VAL) (_EXPR) |
Contributor
There was a problem hiding this comment.
__builtin_expect must not have side effect. Why are we enable the expression?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes nvbug 5983800